fix: issue with providing str for bytes in calldata [APE-667] #1319
+97
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NotPeopling2day
changed the title
antazoey
commented
Feb 25, 2023
antazoey
commented
Feb 25, 2023
antazoey
commented
Feb 27, 2023
|
Note: in debuging the implementation for this with @Ninjagod1251, I figured out that ApeWorX/ethpm-types#63 would be very helpful for some of the code we added |
fubuloubu
reviewed
Feb 28, 2023
| # NOTE: An array can be an array of tuples, so we start with an array check | ||
| if abi_type.type.endswith("]"): | ||
| # remove one layer of the potential onion of array | ||
| new_type = "[".join(str(abi_type.type).split("[")[:-1]) |
There was a problem hiding this comment.
This is the code that I think would be better to fix in ethpm_types.abi.ABIType by adding a method to fetch the inner array type
antazoey
commented
Feb 28, 2023
fubuloubu
previously approved these changes
Mar 1, 2023
|
Fix the linting issue and can merge |
Ninjagod1251
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Just opening this to show @Ninjagod1251 what to do and get it started.
See comments for more info!
fixes: #1289
fixes: APE-627
How I did it
How to verify it
Checklist